Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build/registry): updated go deps. #324

Merged
merged 3 commits into from
Aug 29, 2023
Merged

chore(build/registry): updated go deps. #324

merged 3 commits into from
Aug 29, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 29, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area registry

What this PR does / why we need it:

Updated go deps and ran go mod tidy.
Also, golang for build/registry was bumped to 1.21.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2023

Part of the effort around: falcosecurity/evolution#305

@poiana poiana added the size/XL label Aug 29, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2023

Registry build is broken now :/

make
# github.com/falcosecurity/plugin-sdk-go/pkg/loader
In file included from plugin_loader.c:26:
../../../../go/pkg/mod/github.com/falcosecurity/[email protected]/pkg/sdk/strlcpy.h:30:22: error: static declaration of ‘strlcpy’ follows non-static declaration
   30 | static inline size_t strlcpy(char *dst, const char *src, size_t size) {
      |                      ^~~~~~~
In file included from ../../../../go/pkg/mod/github.com/falcosecurity/[email protected]/pkg/sdk/strlcpy.h:22:
/usr/include/string.h:506:15: note: previous declaration of ‘strlcpy’ with type ‘size_t(char * restrict,  const char * restrict,  size_t)’ {aka ‘long unsigned int(char * restrict,  const char * restrict,  long unsigned int)’}
  506 | extern size_t strlcpy (char *__restrict __dest,
      |               ^~~~~~~
make: *** [Makefile:25: registry] Error 1

@poiana poiana added size/XXL and removed size/XL labels Aug 29, 2023
@FedeDP
chore: bump codeql actions to v2.
7ad961b 
Signed-off-by: Federico Di Pierro <[email protected]>
@leogr leogr mentioned this pull request Aug 29, 2023
Closed
leogr
leogr approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cdbcf9c into falcosecurity:master Aug 29, 2023
11 of 12 checks passed
@leogr
Copy link
Member

leogr commented Aug 29, 2023

Registry build is broken now :/

make
# github.com/falcosecurity/plugin-sdk-go/pkg/loader
In file included from plugin_loader.c:26:
../../../../go/pkg/mod/github.com/falcosecurity/[email protected]/pkg/sdk/strlcpy.h:30:22: error: static declaration of ‘strlcpy’ follows non-static declaration
   30 | static inline size_t strlcpy(char *dst, const char *src, size_t size) {
      |                      ^~~~~~~
In file included from ../../../../go/pkg/mod/github.com/falcosecurity/[email protected]/pkg/sdk/strlcpy.h:22:
/usr/include/string.h:506:15: note: previous declaration of ‘strlcpy’ with type ‘size_t(char * restrict,  const char * restrict,  size_t)’ {aka ‘long unsigned int(char * restrict,  const char * restrict,  long unsigned int)’}
  506 | extern size_t strlcpy (char *__restrict __dest,
      |               ^~~~~~~
make: *** [Makefile:25: registry] Error 1

AFAIK, @jasondellaluce is working on it, right? see #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@leogr leogr

Labels
approved area/registry dco-signoff: yes kind/cleanup lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedeDP @poiana @leogr